Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUILD TEST Gpu limit #1

Open
wants to merge 35 commits into
base: master
Choose a base branch
from
Open

BUILD TEST Gpu limit #1

wants to merge 35 commits into from

Conversation

benoitdm-oslandia
Copy link
Collaborator

Description

[Replace this with some text explaining the rationale and details about this pull request]

Copy link

github-actions bot commented Dec 8, 2023

🪟 Windows builds ready!

Windows builds of this PR are available for testing here. Debug symbols for this build are available here.

(Built from commit 9e6b86d)

nyalldawson and others added 15 commits December 11, 2023 10:31
`unittest.TestCase` is deprecated.
Add QGIS Server tab to QgsVectorTileLayerProperties for configuring shortname/abstract/etc
instead of the generic QgsException one
Refs warning in qgis#55481 (comment)

```
/tmp/work/geography/qgis/work/qgis-3.28.13/build/python/core/build/_core/sip_corepart0.cpp:38168: warning: exception of type 'QgsProviderConnectionException' will be caught
38168 |             catch (QgsProviderConnectionException &sipExceptionRef)
      |
/tmp/work/geography/qgis/work/qgis-3.28.13/build/python/core/build/_core/sip_corepart0.cpp:38158: warning:    by earlier handler for 'QgsException'
38158 |             catch (QgsException &sipExceptionRef)
```
This is achieved with the two following changes:
- add QgsDummyLayer to handle technical layer (for example terrain).
- add QgsTerrainLayer3DRenderer to handle terrain layer.

With this change, this is now possible to remove `mSceneEntities` as
the entities are now also saved in mLayerEntities.
The update scene logic is duplicated in two different places:
- `Qgs3DMapScene::updateScene`
- `Qgs3DMapScene::onFrameTriggered`

In `Qgs3DMapScene::updateScene`, it iterates through the different
mapscene entities, check if th gpu limit has been reached and updates
the scene state flags accordingly.
In `Qgs3DMapScene::onFrameTriggered`, it makes the same thing as
`Qgs3DMapScene::updateScene` but only if needed.
These similar approaches are merged into one by adding a `forceupdate`
boolean.
…eLog and qInstallMessageHandler)

This produces:

* a cleaner and more understandable log management
* all log logic is in QgsLogger::qtMessageHandler
* log format cutomisation via QT_MESSAGE_PATTERN (useful for dev/server usage)
* log message formating is delegated to Qt
* add QGS_LOG_LVL_XXX to help in understand map between number and level
Copy link

github-actions bot commented Dec 14, 2023

Tests failed for Qt 5

One or more tests failed using the build from commit 98bc8ce

composer3d_basic_qt5 (testBasic)

composer3d_basic_qt5

Test failed at testBasic at tests/src/3d/testqgslayout3dmap.cpp:107

Rendered image did not match tests/testdata/control_images/composer_3d/expected_composer3d_basic_qt5/expected_composer3d_basic_qt5.png (found 456044 pixels different)

mesh_terrain_1 (testMeshTerrain)

mesh_terrain_1

Test failed at testMeshTerrain at tests/src/3d/testqgsmesh3drendering.cpp:140

Rendered image did not match tests/testdata/control_images/3d/expected_mesh_terrain_1/expected_mesh_terrain_1.png (found 93750 pixels different)

The full test report (included comparison of rendered vs expected images) can be found here.

Further documentation on the QGIS test infrastructure can be found in the Developer's Guide.

Copy link

Tests failed for Qt 6

One or more tests failed using the build from commit 98bc8ce

composer3d_basic_qt6 (testBasic)

composer3d_basic_qt6

Test failed at testBasic at tests/src/3d/testqgslayout3dmap.cpp:109

Rendered image did not match tests/testdata/control_images/composer_3d/expected_composer3d_basic_qt6/expected_composer3d_basic_qt6.png (found 456133 pixels different)

mesh_terrain_1 (testMeshTerrain)

mesh_terrain_1

Test failed at testMeshTerrain at tests/src/3d/testqgsmesh3drendering.cpp:140

Rendered image did not match tests/testdata/control_images/3d/expected_mesh_terrain_1/expected_mesh_terrain_1.png (found 93750 pixels different)

The full test report (included comparison of rendered vs expected images) can be found here.

Further documentation on the QGIS test infrastructure can be found in the Developer's Guide.

ptitjano pushed a commit that referenced this pull request Jan 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants